instantsend: Do not consider islocks with unknown txes as complete #4147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
changed the title
Member
|
Removed backport candidate label, I don't think this is a suitable change for 0.17 this close to release |
UdjinM6
force-pushed
the
no_notx_islocks
branch
2 times, most recently
from
7fc32fd to
2aa7697
Compare
|
This pull request has conflicts, please rebase. |
UdjinM6
force-pushed
the
no_notx_islocks
branch
from
2aa7697 to
ca02fdb
Compare
UdjinM6
force-pushed
the
no_notx_islocks
branch
2 times, most recently
from
17897b8 to
6fa6b79
Compare
|
This pull request has conflicts, please rebase. |
1 similar comment
|
This pull request has conflicts, please rebase. |
UdjinM6
force-pushed
the
no_notx_islocks
branch
from
6fa6b79 to
3c58667
Compare
UdjinM6
force-pushed
the
no_notx_islocks
branch
2 times, most recently
from
e5a0772 to
c404b0c
Compare
UdjinM6
force-pushed
the
no_notx_islocks
branch
from
c404b0c to
3aba148
Compare
UdjinM6
force-pushed
the
no_notx_islocks
branch
from
3aba148 to
91c46fe
Compare
PastaPastaPasta
approved these changes
Nov 30, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 11, 2023
…ashpay#4147) * instantsend: Avoid writing IS locks for unknown txes * instantsend: Allow a competing tx into mempool if there is an islock waiting for it * use try_emplace * Hold cs_main while calling ResetBlockFailureFlags
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
…ashpay#4147) * instantsend: Avoid writing IS locks for unknown txes * instantsend: Allow a competing tx into mempool if there is an islock waiting for it * use try_emplace * Hold cs_main while calling ResetBlockFailureFlags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store incomplete islocks separately (mem only), allow competing txes until the corresponding tx is known.
Based on #4146 atm.