Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): bump quorum_data_request_expiration_timeout to fix p2p_quorum_data.py #5281

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Mar 30, 2023

Issue being fixed or feature implemented

fix p2p_quorum_data.py test broken by #5276

What was done?

adjust data request expiration timeout in tests

How Has This Been Tested?

./test/functional/test_runner.py p2p_quorum_data.py

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

…quorum_data.py`

the test was broken by 5276
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge; sure

@PastaPastaPasta PastaPastaPasta merged commit 6e00fd0 into dashpay:develop Mar 30, 2023
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 30, 2023
…quorum_data.py` (dashpay#5281)

## Issue being fixed or feature implemented
fix `p2p_quorum_data.py` test broken by dashpay#5276


## What was done?
adjust data request expiration timeout in tests

## How Has This Been Tested?
`./test/functional/test_runner.py p2p_quorum_data.py`

## Breaking Changes
n/a

## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [x] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation

**For repository code-owners and collaborators only**
- [x] I have assigned this pull request to a milestone
@UdjinM6 UdjinM6 deleted the fix_5276 branch March 30, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants