feat: store protx version in CSimplifiedMNListEntry and use it to ser/deser pubKeyOperator #5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
UdjinM6
force-pushed
the
smnle_versioned
branch
2 times, most recently
from
0c4b514
to
2e5cca0
Compare
UdjinM6
changed the title
|
This pull request has conflicts, please rebase. |
…/deser pubKeyOperator
should also match the scheme it was created with in the original protx and match nVersion in CSimplifiedMNListEntry
PastaPastaPasta
approved these changes
Jun 11, 2023
There was a problem hiding this comment.
@ogabrielides I'd like you to review this, but in mean time; let's get 19.2-rc.1 out
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Jun 11, 2023
…/deser pubKeyOperator (dashpay#5397) Mobile wallets would have to convert 4k+ pubkeys at the V19 fork point and it's a pretty hard job for them that can easily take 10-15 seconds if not more. Also after the HF, if a masternode list is requested from before the HF, the operator keys come in basic scheme, but the merkelroot was calculated with legacy. From mobile team work it wasn't possible to convert all operator keys to legacy and then calculate the correct merkleroot. ~This PR builds on top of ~dashpay#5392~ dashpay#5403 (changes that belong to this PR: 26f7e96 and 4b42dc8) and aims to solve both of these issues.~ cc @HashEngineering @QuantumExplorer Introduce `nVersion` on p2p level for every CSimplifiedMNListEntry. Set `nVersion` to the same value we have it in CDeterministicMNState i.e. pubkey serialization would not be via basic scheme only after the V19 fork, it would match the way it’s serialized on-chain/in CDeterministicMNState for that specific MN. run tests NOTE: `testnet` is going to re-fork at v19 forkpoint because `merkleRootMNList` is not going to match - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 12, 2023
…/deser pubKeyOperator (dashpay#5397) Mobile wallets would have to convert 4k+ pubkeys at the V19 fork point and it's a pretty hard job for them that can easily take 10-15 seconds if not more. Also after the HF, if a masternode list is requested from before the HF, the operator keys come in basic scheme, but the merkelroot was calculated with legacy. From mobile team work it wasn't possible to convert all operator keys to legacy and then calculate the correct merkleroot. ~This PR builds on top of ~dashpay#5392~ dashpay#5403 (changes that belong to this PR: 26f7e96 and 4b42dc8) and aims to solve both of these issues.~ cc @HashEngineering @QuantumExplorer Introduce `nVersion` on p2p level for every CSimplifiedMNListEntry. Set `nVersion` to the same value we have it in CDeterministicMNState i.e. pubkey serialization would not be via basic scheme only after the V19 fork, it would match the way it’s serialized on-chain/in CDeterministicMNState for that specific MN. run tests NOTE: `testnet` is going to re-fork at v19 forkpoint because `merkleRootMNList` is not going to match - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 12, 2023
…/deser pubKeyOperator (dashpay#5397) Mobile wallets would have to convert 4k+ pubkeys at the V19 fork point and it's a pretty hard job for them that can easily take 10-15 seconds if not more. Also after the HF, if a masternode list is requested from before the HF, the operator keys come in basic scheme, but the merkelroot was calculated with legacy. From mobile team work it wasn't possible to convert all operator keys to legacy and then calculate the correct merkleroot. ~This PR builds on top of ~dashpay#5392~ dashpay#5403 (changes that belong to this PR: 26f7e96 and 4b42dc8) and aims to solve both of these issues.~ cc @HashEngineering @QuantumExplorer Introduce `nVersion` on p2p level for every CSimplifiedMNListEntry. Set `nVersion` to the same value we have it in CDeterministicMNState i.e. pubkey serialization would not be via basic scheme only after the V19 fork, it would match the way it’s serialized on-chain/in CDeterministicMNState for that specific MN. run tests NOTE: `testnet` is going to re-fork at v19 forkpoint because `merkleRootMNList` is not going to match - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
thephez
added a commit
to thephez/docs-core
that referenced
this pull request
Jun 14, 2023
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Jun 20, 2023
* docs(rpc): update protx list for 19.2 * docs(rpc): update quick reference * docs(rpc): update protx info for 19.2 * docs(rpc): minor update to protx diff and example updated * chore: update protx diff example command to match results * docs(rpc): update masternode status for 19.2 * chore: minor formatting update * docs(rpc): update quick ref * docs: update protocol version * chore: add DIP-28 link * docs(p2p): add nVersion to sml entry From dashpay/dash#5397 * docs(p2p): update dsq and dstx for 19.2 Will use protx instead of mn outpoint after v19 activation per dashpay/dash#5404 * docs(rpc): update masternode status example * docs(p2p): minor updates to mnlistdiff change order of some fields. mnlistdiff version always 1 * docs(rpc): update masternode status example output * docs(rpc): update protx diff field location and example output * Update docs/reference/transactions-special-transactions.md Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Jun 21, 2023
* docs: spork updates (#35) * docs: integrate spork 6 info into paragraph * docs: add updated info about spork 19 and refactor spork values info * chore: update url and formatting * chore: remove sporks deprecated more than 4 versions ago * style: inconsistent list ending * refactor: relocate hexdump to better location and add subheadings * fix: correct typo * feat: 19.2 rpc updates (#36) * docs(rpc): update protx list for 19.2 * docs(rpc): update quick reference * docs(rpc): update protx info for 19.2 * docs(rpc): minor update to protx diff and example updated * chore: update protx diff example command to match results * docs(rpc): update masternode status for 19.2 * chore: minor formatting update * docs(rpc): update quick ref * docs: update protocol version * chore: add DIP-28 link * docs(p2p): add nVersion to sml entry From dashpay/dash#5397 * docs(p2p): update dsq and dstx for 19.2 Will use protx instead of mn outpoint after v19 activation per dashpay/dash#5404 * docs(rpc): update masternode status example * docs(p2p): minor updates to mnlistdiff change order of some fields. mnlistdiff version always 1 * docs(rpc): update masternode status example output * docs(rpc): update protx diff field location and example output * Update docs/reference/transactions-special-transactions.md Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Mobile wallets would have to convert 4k+ pubkeys at the V19 fork point and it's a pretty hard job for them that can easily take 10-15 seconds if not more. Also after the HF, if a masternode list is requested from before the HF, the operator keys come in basic scheme, but the merkelroot was calculated with legacy. From mobile team work it wasn't possible to convert all operator keys to legacy and then calculate the correct merkleroot.
This PR builds on top of#5392#5403 (changes that belong to this PR: 26f7e96 and 4b42dc8) and aims to solve both of these issues.cc @HashEngineering @QuantumExplorer
What was done?
Introduce
nVersionon p2p level for every CSimplifiedMNListEntry. SetnVersionto the same value we have it in CDeterministicMNState i.e. pubkey serialization would not be via basic scheme only after the V19 fork, it would match the way it’s serialized on-chain/in CDeterministicMNState for that specific MN.How Has This Been Tested?
run tests
Breaking Changes
NOTE:
testnetis going to re-fork at v19 forkpoint becausemerkleRootMNListis not going to matchChecklist: