feat: use m_protxHash instead of masternodeOutpoint for hashing dsq and dstx after v19 activation #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd dstx after v19 activation
|
Any reason to not make this backwards compatible based on PROTO version instead of hard fork status? Seems bad to break mixing for electrum clients for example (although likely not many people use this) |
|
It's much worse to have a 19.1 vs 19.2 split in mixing pools imo cause less compatible MNs to mix at (and clients to mix with) means that mixing is going to be slower and less secure for both versions. Also, non-core mixing clients would have to update anyway cause bls sigs are going to change from legacy to bls too so they won't be able to verify |
PastaPastaPasta
approved these changes
Jun 8, 2023
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 11, 2023
…nd dstx after v19 activation (dashpay#5404) ## Issue being fixed or feature implemented Should fix dashpay#5401 with minimal potential coinjoin service interruption (~1 minute around v19 fork point) for up to date clients. Fully backwards compatible prior to v19 activation. Old clients won't be able to mix after v19 activation though until they implement similar changes. _EDIT: Actually, this is already the case cause bls sigs are going to change too._ And I think we should also be able to finally drop `masternodeOutpoint` from `CCoinJoinQueue` and `CCoinJoinBroadcastTx` once v19 is active because of that which would be a nice bonus. cc @HashEngineering ## What was done? re-use v19 activation to switch `GetSignatureHash` logic ## How Has This Been Tested? mixing on mainnet ## Breaking Changes mixing won't work on current testnet until MNs are updated ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
thephez
added a commit
to thephez/docs-core
that referenced
this pull request
Jun 14, 2023
Will use protx instead of mn outpoint after v19 activation per dashpay/dash#5404
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Jun 20, 2023
* docs(rpc): update protx list for 19.2 * docs(rpc): update quick reference * docs(rpc): update protx info for 19.2 * docs(rpc): minor update to protx diff and example updated * chore: update protx diff example command to match results * docs(rpc): update masternode status for 19.2 * chore: minor formatting update * docs(rpc): update quick ref * docs: update protocol version * chore: add DIP-28 link * docs(p2p): add nVersion to sml entry From dashpay/dash#5397 * docs(p2p): update dsq and dstx for 19.2 Will use protx instead of mn outpoint after v19 activation per dashpay/dash#5404 * docs(rpc): update masternode status example * docs(p2p): minor updates to mnlistdiff change order of some fields. mnlistdiff version always 1 * docs(rpc): update masternode status example output * docs(rpc): update protx diff field location and example output * Update docs/reference/transactions-special-transactions.md Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Jun 21, 2023
* docs: spork updates (#35) * docs: integrate spork 6 info into paragraph * docs: add updated info about spork 19 and refactor spork values info * chore: update url and formatting * chore: remove sporks deprecated more than 4 versions ago * style: inconsistent list ending * refactor: relocate hexdump to better location and add subheadings * fix: correct typo * feat: 19.2 rpc updates (#36) * docs(rpc): update protx list for 19.2 * docs(rpc): update quick reference * docs(rpc): update protx info for 19.2 * docs(rpc): minor update to protx diff and example updated * chore: update protx diff example command to match results * docs(rpc): update masternode status for 19.2 * chore: minor formatting update * docs(rpc): update quick ref * docs: update protocol version * chore: add DIP-28 link * docs(p2p): add nVersion to sml entry From dashpay/dash#5397 * docs(p2p): update dsq and dstx for 19.2 Will use protx instead of mn outpoint after v19 activation per dashpay/dash#5404 * docs(rpc): update masternode status example * docs(p2p): minor updates to mnlistdiff change order of some fields. mnlistdiff version always 1 * docs(rpc): update masternode status example output * docs(rpc): update protx diff field location and example output * Update docs/reference/transactions-special-transactions.md Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Should fix #5401 with minimal potential coinjoin service interruption (~1 minute around v19 fork point) for up to date clients. Fully backwards compatible prior to v19 activation. Old clients won't be able to mix after v19 activation though until they implement similar changes. EDIT: Actually, this is already the case cause bls sigs are going to change too. And I think we should also be able to finally drop
masternodeOutpointfromCCoinJoinQueueandCCoinJoinBroadcastTxonce v19 is active because of that which would be a nice bonus.cc @HashEngineering
What was done?
re-use v19 activation to switch
GetSignatureHashlogicHow Has This Been Tested?
mixing on mainnet
Breaking Changes
mixing won't work on current testnet until MNs are updated
Checklist: