fix: multiple 5403 followups #5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK; reindexing main net and testnet to ensure all works as expected |
PastaPastaPasta
approved these changes
Jun 11, 2023
…is included in CDeterministicMNStateDiff
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 11, 2023
- CBLSLazyWrapper is doing to much and not enough at the same time - nVersion assignment in CDeterministicMNState(Diff) is incomplete - pubKeyOperator deserialization needs nVersion but nVersion is deser-ed much later - protx rpcs are implicitly converting pubKeyOperator (by forcing nVersion=2), they shouldn't do that pls see individual commits - [x] run tests locally - [x] reindex on testnet: - [x] with and without `--assumevalid=0` to the tip - [x] with 19.1 almost to the forkpoint, then with this version - [x] reindex on mainnet: - [x] with and without `--assumevalid=0` to the tip - [x] with 19.1 to height 1100000+, then with this version might need reindexing if you were running develop on testnet already - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 12, 2023
- CBLSLazyWrapper is doing to much and not enough at the same time - nVersion assignment in CDeterministicMNState(Diff) is incomplete - pubKeyOperator deserialization needs nVersion but nVersion is deser-ed much later - protx rpcs are implicitly converting pubKeyOperator (by forcing nVersion=2), they shouldn't do that pls see individual commits - [x] run tests locally - [x] reindex on testnet: - [x] with and without `--assumevalid=0` to the tip - [x] with 19.1 almost to the forkpoint, then with this version - [x] reindex on mainnet: - [x] with and without `--assumevalid=0` to the tip - [x] with 19.1 to height 1100000+, then with this version might need reindexing if you were running develop on testnet already - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
thephez
reviewed
Jun 13, 2023
Merged
5 tasks
PastaPastaPasta
pushed a commit
that referenced
this pull request
Jun 17, 2023
…implifiedMNListDiff (#5434) ## Issue being fixed or feature implemented Should fix #5424 (comment) and make `CSimplifiedMNListEntry`'s json a bit more human-friendly (imo) by having `nVersion` and `nType` at the top of it. Move `nVersion` up for `CSimplifiedMNListDiff` too. NOTE: `nVersion` wasn't actually duplicated in rpc results, it was simply assigned twice inside. still not nice though. Thanks @thephez ! 👍 ## What was done? ## How Has This Been Tested? ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Jun 17, 2023
…implifiedMNListDiff (dashpay#5434) ## Issue being fixed or feature implemented Should fix dashpay#5424 (comment) and make `CSimplifiedMNListEntry`'s json a bit more human-friendly (imo) by having `nVersion` and `nType` at the top of it. Move `nVersion` up for `CSimplifiedMNListDiff` too. NOTE: `nVersion` wasn't actually duplicated in rpc results, it was simply assigned twice inside. still not nice though. Thanks @thephez ! 👍 ## What was done? ## How Has This Been Tested? ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
pls see individual commits
How Has This Been Tested?
--assumevalid=0to the tip--assumevalid=0to the tipBreaking Changes
might need reindexing if you were running develop on testnet already
Checklist: