feat(rpc): quorum dkginfo rpc

[ogabrielides]

Issue being fixed or feature implemented

Dashmate wanted a way to know if it is safe to restart the masternode.
This new RPC indicates the number of active DKG sessions, and the number of blocks until next potential DKG.

What was done?

Examples of responses:
{'active_dkgs': 0, 'next_dkg': 22}

How Has This Been Tested?

feature_llmq_rotation.py was updated

Breaking Changes

no

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[DashCoreAutoGuix]

Guix Automation has began to build this PR tagged as v20.1.0-devpr5853.8386a3d6. A new comment will be made when the image is pushed.

[DashCoreAutoGuix]

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v20.1.0-devpr5853.8386a3d6. The image should be on dockerhub soon.

[qwizzie]

Note that this RPC is allowed only for masternodes

Does this mean this new RPC can not be used for Evonodes ? Is there a different approach to masternodes (this pull request) and evonodes (adds a check in stopNodeTaskFactory through a Platform pull request). Or are both pull requests focused just on masternodes for now ? See : dashpay/platform#1683

[thephez]

Note that this RPC is allowed only for masternodes

Does this mean this new RPC can not be used for Evonodes ? Is there a different approach to masternodes (this pull request) and evonodes (adds a check in stopNodeTaskFactory through a Platform pull request). Or are both pull requests focused just on masternodes for now ? See : dashpay/platform#1683

I don't think so. In my mind (and I think how it's referred to here), an evonode is just a particular type of masternode. Regular MNs and evonodes are both subsets of the generic "masternode".

[kxcd]

WOW! This could be really useful, if it works !

[kxcd]

It is not better to slot this RPC under quorum ?

[ogabrielides]

It is not better to slot this RPC under quorum ?

Yes, you are right.

[thephez]

It could be valuable to include nextDKG always That way you'd always know how far in the future the next DKG was (even if in the middle of DKG already).

[UdjinM6]

few suggestions, see below (all of them squashed 44467c0)

[UdjinM6]

utACK

[thephez]

👍

[PastaPastaPasta]

utACK for squash merge