-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashmate): check for DKG before stopping node #1683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshenmic
requested review from
shumkov,
antouhou and
QuantumExplorer
as code owners
January 30, 2024 19:43
shumkov
requested changes
Jan 31, 2024
shumkov
requested changes
Jan 31, 2024
5 tasks
pshenmic
force-pushed
the
feat/dashmate-dkg-check
branch
from
May 4, 2024 19:51
630e208
to
a2422f4
Compare
shumkov
requested changes
May 6, 2024
shumkov
requested changes
May 8, 2024
shumkov
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Nice job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#1648
When node is participating in DKG exchange process, it is dangerous to restart the node, because it can result to the PoSe ban.
Recently, Dash Core v20.1 was released that include a
quorum dkginfo
RPC call, that shows if nodes is exchanging DKG or will in the upcoming blocks.This PR adds a check for that before stopping node.
What was done?
dashmate stop
command (reduce PoSE bans)dashmate stop
command, that will wait until DKG window passes and flawlessly stops your nodeHow Has This Been Tested?
Locally with dashmate in testnet and local setups
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only