refactor: extract CActiveMasternodeManager from LLMQContext (3/n, DKG session isolation, ActiveContext consolidation)
#7065
+4,633
−3,634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dash-chainstate may not have ArgsManager, we should try and resolve the expected value before moving to chainstate logic.
Same rationale as previous commit.
Same rationale as previous commit.
Same rationale as previous commit.
The context that creates the signer should register the listener rather than relying on the timing being exactly right on when Start() is called by the controlling manager. Also: - Use more descriptive function names replacing Start()/Stop() - Fixup order of events in ActiveContext c/dtor and Start()/Stop()
The `ConnectManager` approach is no longer needed.
Also: - Drop unneeded argument from LLMQContext::Start() - Drop LLMQContext::Interrupt() that does nothing
We are going to modify PeerManager multiple times, this should make the diffs that'll attract smaller.
Needed when `CActiveMasternodeManager` is moved to `ActiveContext`
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Also gives us the help text for `gobject list-prepared`
Also gives us the help text for `gobject {diff,list}`
As we're isolating watch-only and masternode mode logic, we won't have access to the DKG debug object anymore, restrict access in preparation.
`mapQuorumDataRequests` isn't used outside `CQuorumManager` and a `RecursiveMutex` is unnecessary for the usage pattern
These subroutines do nothing unless we are in masternode mode so we need to extract them in order to isolate it from regular mode.
Also: - Drop avoidable `CActiveMasternodeManager&` arg by taking ref of hash we care about
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
This is done to remove m_mn_activeman calls from within the worker to allow us to run it in watch-only mode.
Needed to split logic based on watch-only or masternode-mode in next commit.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Right now we have a circular dependency between `CQuorumManager`'s TU and the handler's TU's but we also house common code in the former, we need to split it out before we can close the gap. Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Handlers are initialized from contexts with complete knowledge of P2P, so we can trim down the arguments passed a fair bit. Also: - Move `UpdatedBlockTip()` to handler parent contexts and out of `CQuorumManager`
We need to split up the cache warming thread with the rest of the tasks given the thread pool used by the handlers as we start to isolate impl. details of the parent.
Required for upcoming commits.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Also: - Drop stale TODO, remove headers in code that no longer refer to masternode capabilities
Now that `ActiveNotificationInterface` exclusively calls `ActiveContext` we can now merge them together. Also: - Drop `LLMQContext` from `ActiveContext`, only import what we use
Also: - Headers cleanup
5 tasks
|
kwvg
changed the title
CActiveMasternodeManager from LLMQContext (3/3, DKG session isolation, ActiveContext consolidation)CActiveMasternodeManager from LLMQContext (3/n, DKG session isolation, ActiveContext consolidation)
5 tasks
|
This pull request has conflicts, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
Depends on refactor: extract
CActiveMasternodeManagerfromLLMQContext(2/n,CQuorumManagerhandler separation) #7063Dependency for refactor: extract
CActiveMasternodeManagerfromLLMQContext(4/n, followups) #7066Breaking Changes
None expected.
Checklist: