refactor: extract CActiveMasternodeManager from LLMQContext (4/n, followups)
#7066
+4,904
−3,854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dash-chainstate may not have ArgsManager, we should try and resolve the expected value before moving to chainstate logic.
Same rationale as previous commit.
Same rationale as previous commit.
Same rationale as previous commit.
The context that creates the signer should register the listener rather than relying on the timing being exactly right on when Start() is called by the controlling manager. Also: - Use more descriptive function names replacing Start()/Stop() - Fixup order of events in ActiveContext c/dtor and Start()/Stop()
The `ConnectManager` approach is no longer needed.
Also: - Drop unneeded argument from LLMQContext::Start() - Drop LLMQContext::Interrupt() that does nothing
We are going to modify PeerManager multiple times, this should make the diffs that'll attract smaller.
Needed when `CActiveMasternodeManager` is moved to `ActiveContext`
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Also gives us the help text for `gobject list-prepared`
Also gives us the help text for `gobject {diff,list}`
As we're isolating watch-only and masternode mode logic, we won't have access to the DKG debug object anymore, restrict access in preparation.
`mapQuorumDataRequests` isn't used outside `CQuorumManager` and a `RecursiveMutex` is unnecessary for the usage pattern
These subroutines do nothing unless we are in masternode mode so we need to extract them in order to isolate it from regular mode.
Also: - Drop avoidable `CActiveMasternodeManager&` arg by taking ref of hash we care about
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Also: - Drop stale TODO, remove headers in code that no longer refer to masternode capabilities
Now that `ActiveNotificationInterface` exclusively calls `ActiveContext` we can now merge them together. Also: - Drop `LLMQContext` from `ActiveContext`, only import what we use
Also: - Headers cleanup
Resolves a TODO
Resolves a TODO
Most usage is not ordering-sensitive, can reduce lookup complexity.
5 tasks
|
Also: - Don't start DKG logger if we expect to bail right after in ActiveSession
|
This pull request has conflicts, please rebase. |
This was referenced Dec 18, 2025
Merged
PastaPastaPasta
added a commit
that referenced
this pull request
Dec 23, 2025
8e44990 chore!: enforce ban for re-propagation of stale `QFCOMMIT`s (Kittywhiskers Van Gogh) Pull request description: ## Additional Information Spun off from [dash#7066](#7066) due to breaking change, enforces policy introduced in [dash#5145](#5145). ## Breaking changes Broadcasting stale `QFCOMMIT`s will result in the offending node getting banned. ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 8e44990; since this is protocol version guarded; not a breaking change. UdjinM6: utACK 8e44990 Tree-SHA512: 659e43fba896ac3046dfc7aa197ab0a2207e1648488fdcd545902a90d4efa4f25d74f4a92b99eb2e68cf96b30a78a99114d9487c1abf0b8954dc7a585131d88b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
CActiveMasternodeManagerfromLLMQContext(3/n, DKG session isolation,ActiveContextconsolidation) #7065Breaking Changes
Work in progress.
Checklist