Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate estimators #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Deprecate estimators #66

wants to merge 2 commits into from

Conversation

TomAugspurger
Copy link
Member

Closes #63

xref dask/dask-ml#94

@jakirkham
Copy link
Member

LGTM

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @TomAugspurger!

I added two comments for updated documentation links. There are also a couple of things flake8 doesn't like. Otherwise LGTM

@@ -30,3 +30,4 @@ Indices and tables
.. _dask: http://dask.pydata.org/en/latest/
.. _GLM: https://en.wikipedia.org/wiki/Generalized_linear_model
.. _scikit-learn: http://scikit-learn.org/
.. _dask-ml: http://dask-ml.readthedocs.org/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. _dask-ml: http://dask-ml.readthedocs.org/
.. _dask-ml: https://ml.dask.org/

@@ -30,3 +30,4 @@ Indices and tables
.. _dask: http://dask.pydata.org/en/latest/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. _dask: http://dask.pydata.org/en/latest/
.. _dask: https://docs.dask.org/

@TomAugspurger
Copy link
Member Author

TomAugspurger commented Mar 21, 2019 via email

Base automatically changed from master to main February 10, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants