-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate estimators #66
base: main
Are you sure you want to change the base?
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this @TomAugspurger!
I added two comments for updated documentation links. There are also a couple of things flake8
doesn't like. Otherwise LGTM
@@ -30,3 +30,4 @@ Indices and tables | |||
.. _dask: http://dask.pydata.org/en/latest/ | |||
.. _GLM: https://en.wikipedia.org/wiki/Generalized_linear_model | |||
.. _scikit-learn: http://scikit-learn.org/ | |||
.. _dask-ml: http://dask-ml.readthedocs.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. _dask-ml: http://dask-ml.readthedocs.org/ | |
.. _dask-ml: https://ml.dask.org/ |
@@ -30,3 +30,4 @@ Indices and tables | |||
.. _dask: http://dask.pydata.org/en/latest/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. _dask: http://dask.pydata.org/en/latest/ | |
.. _dask: https://docs.dask.org/ |
I won’t be able to update this in the near future. If anyone is able to push it through I’d appreciate it.
________________________________
From: James Bourbeau <notifications@github.com>
Sent: Wednesday, March 20, 2019 10:07 AM
To: dask/dask-glm
Cc: Tom Augspurger; Mention
Subject: Re: [dask/dask-glm] Deprecate estimators (#66)
@jrbourbeau commented on this pull request.
Thanks for updating this @TomAugspurger<https://github.com/TomAugspurger>!
I added two comments for updated documentation links. There are also a couple of things flake8 doesn't like. Otherwise LGTM
________________________________
In docs/index.rst<#66 (comment)>:
@@ -30,3 +30,4 @@ Indices and tables
.. _dask: http://dask.pydata.org/en/latest/
.. _GLM: https://en.wikipedia.org/wiki/Generalized_linear_model
.. _scikit-learn: http://scikit-learn.org/
+.. _dask-ml: http://dask-ml.readthedocs.org/
⬇️ Suggested change
-.. _dask-ml: http://dask-ml.readthedocs.org/
+.. _dask-ml: https://ml.dask.org/
________________________________
In docs/index.rst<#66 (comment)>:
@@ -30,3 +30,4 @@ Indices and tables
.. _dask: http://dask.pydata.org/en/latest/
⬇️ Suggested change
- .. _dask: http://dask.pydata.org/en/latest/
+.. _dask: https://docs.dask.org/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#66 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIuPtjqNTz7-pElHaZD4o-SiUbOd4ks5vYk6pgaJpZM4Qf2qr>.
|
Closes #63
xref dask/dask-ml#94