Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GLM estimators in dask-ml #94

Merged
merged 14 commits into from
Dec 1, 2017

Conversation

TomAugspurger
Copy link
Member

Moving them here from dask-glm.

No changes to the API yet.

Moving them here from dask-glm
@PeterDSteinberg
Copy link

Thanks @TomAugspurger - you beat me to it - Is the goal for this PR to make dask-glm installation no longer required for dask-ml - essentially moving all of its assets to the new subpackage here? That would be my vote but it's not critical to me.

@TomAugspurger
Copy link
Member Author

dask-glm will still be a required dependency, as the optimizers and regularizers will still live there. Just the scikit-learn style estimators are moving here.

@@ -82,6 +82,48 @@ def make_counts(n_samples=1000, n_features=100, n_informative=2, scale=1.0,
return X, y


def make_poisson(n_samples=1000, n_features=100, n_informative=2, scale=1.0,
Copy link

@MLnick MLnick Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be exactly the same as make_counts above? Is it meant to be a copy-over of the make_classification and make_regression from GLM?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks.

@TomAugspurger TomAugspurger merged commit 0667ea3 into dask:master Dec 1, 2017
@TomAugspurger TomAugspurger deleted the glm-estimators branch December 1, 2017 17:44
TomAugspurger added a commit to dsevero/dask-ml that referenced this pull request Jan 15, 2018
* Implement GLM estimators in dask-ml

Moving them here from dask-glm

* Flake8 fixups

* Added multipledispatch

* Refactor

Match scikit-learn style, handle dataframe

* More API changes

* More solver kwarg validation

* Cleanup imports

* Docstring

* Added release notes

* Reformat

* Encoding

* Remove duplicate poisson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants