Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support running experimental KubeClusters and HelmClusters on the same loop as another SyncMethodMixin instance #493

Merged
merged 9 commits into from
May 18, 2022
Merged

support running experimental KubeClusters and HelmClusters on the same loop as another SyncMethodMixin instance #493

merged 9 commits into from
May 18, 2022

Conversation

graingert
Copy link
Member

@graingert graingert commented May 17, 2022 •
edited
Loading

@graingert graingert marked this pull request as ready for review May 17, 2022 13:19
@graingert graingert force-pushed the remove-calls-to-loop-runner branch 2 times, most recently from bfc9b11 to 534c82e Compare May 17, 2022 14:20
@graingert
Copy link
Member Author

currently the distributed.LoopRunner grabs the event loop from the current thread and runs it in a different thread.

which results in pytest-asyncio trying to close it when run in auto mode:
https://github.com/dask/dask-kubernetes/runs/6472536358?check_suite_focus=true#step:5:155

once dask/distributed#6163 is fixed this should go away

@jacobtomlinson jacobtomlinson mentioned this pull request May 18, 2022
Closed
@jacobtomlinson
Copy link
Member

jacobtomlinson commented May 18, 2022 •
edited
Loading

CI failures here seem to be related to install_signal_handlers being dropped without warning in dask/distributed/pull/6205 which has broken dask-ctl. Raised dask-contrib/dask-ctl/pull/41 to try and resolve.

@hendrikmakait hendrikmakait mentioned this pull request May 18, 2022
Merged
2 tasks
@jacobtomlinson jacobtomlinson merged commit 856d7f3 into dask:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @jacobtomlinson