Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore install_signal_handlers due to downstream dependencies #6366

Merged

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented May 18, 2022

Restores the install_signal_handlers function removed in #6205 due to downstream dependencies in e.g. dask-ctl and dask-kubernetes.

XREF: dask/dask-kubernetes/pull/493
XREF: dask-contrib/dask-ctl/pull/41

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hendrikmakait hendrikmakait marked this pull request as ready for review May 18, 2022 13:41
@hendrikmakait hendrikmakait force-pushed the restore-install_signal_handlers branch from 6cb42e5 to 31c9f28 Compare May 18, 2022 13:45
@hendrikmakait hendrikmakait requested a review from graingert May 18, 2022 13:45
@hendrikmakait
Copy link
Member Author

hendrikmakait commented May 18, 2022

FYI, I don't have permission to merge, so somebody else will have to take it from here.

@jacobtomlinson jacobtomlinson merged commit ff94776 into dask:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants