Type annotations for Worker and gen_cluster #5438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Oct 18, 2021
| @@ -733,6 +849,8 @@ def __init__( | |||
| dict(startup_information) if startup_information else {} | |||
| ) | |||
|
|
|||
| if low_level_profiler is None: | |||
| low_level_profiler = dask.config.get("distributed.worker.profile.low-level") | |||
There was a problem hiding this comment.
Read config at init time instead of module load time
crusaderky
commented
Oct 18, 2021
| @@ -794,14 +912,14 @@ def __init__( | |||
| pc = PeriodicCallback(self.find_missing, 1000) | |||
| self.periodic_callbacks["find-missing"] = pc | |||
|
|
|||
| self._suspicious_count_limit = 10 | |||
|
All failures are unrelated. Ready for review. |
fjetter
approved these changes
Oct 19, 2021
pentschev
added a commit
to pentschev/dask-cuda
that referenced
this pull request
Oct 20, 2021
Changes from dask/distributed#5438 have slightly modified the behavior for worker spilling options, thus we need to update memory_pause_fraction to a value that isn't `None`.
rapids-bot bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
Oct 20, 2021
Changes from dask/distributed#5438 have slightly modified the behavior for worker spilling options, thus we need to update memory_pause_fraction to a value that isn't `None`. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Benjamin Zaitlen (https://github.com/quasiben) URL: #757
3 tasks
zanieb
pushed a commit
to zanieb/distributed
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.