Update memory_pause_fraction in test_spill #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes from dask/distributed#5438 have slightly modified the behavior for worker spilling options, thus we need to update memory_pause_fraction to a value that isn't `None`.
pentschev
added
3 - Ready for Review
|
Failures should be fixed by rapidsai/cudf#9481 . |
|
rerun tests |
1 similar comment
|
rerun tests |
quasiben
reviewed
Oct 20, 2021
| @@ -82,6 +82,7 @@ def main(args): | |||
| "ignore", message=".*NVLink.*rmm_pool_size.*", category=UserWarning | |||
| ) | |||
|
|
|||
| print(cluster_kwargs) | |||
There was a problem hiding this comment.
Is this leftover from testing or you do want to print kwargs ?
There was a problem hiding this comment.
This is something I was using for a different test and didn't see when committing, good catch. Removed it now.
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #757 +/- ##
===============================================
Coverage ? 79.98%
===============================================
Files ? 15
Lines ? 1974
Branches ? 0
===============================================
Hits ? 1579
Misses ? 395
Partials ? 0 Continue to review full report at Codecov.
|
quasiben
approved these changes
Oct 20, 2021
|
@gpucibot merge |
|
Thanks @quasiben ! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from dask/distributed#5438 have slightly
modified the behavior for worker spilling options, thus we need to
update memory_pause_fraction to a value that isn't
None.