Fix race condition with Nanny.on_exit_sync
callback
#6664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #6625
We have a race condition with the
Nanny.on_exit_sync
callback, which might be executed after the_ongoing_background_tasks
are already closed, resulting in anAsyncTaskGroupClosedError
. In that case, something else is already closing the nanny, so we do not need to bother. Ideally, theon_exit
andclose
logic would be generally cleaned up and avoid concurrent invocations, but that will likely need to be a more elaborate fix.https://github.com/fjetter/distributed/runs/7090337573?check_suite_focus=true#step:11:3425
pre-commit run --all-files