Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition with Nanny.on_exit_sync callback #6664

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix race condition with Nanny.on_exit_sync callback #6664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion distributed/nanny.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from distributed.comm import get_address_host
from distributed.comm.addressing import address_from_user_args
from distributed.core import (
AsyncTaskGroupClosedError,
CommClosedError,
RPCClosed,
Status,
Expand Down Expand Up @@ -498,7 +499,10 @@ def run(self, comm, *args, **kwargs):
return run(self, comm, *args, **kwargs)

def _on_exit_sync(self, exitcode):
self._ongoing_background_tasks.call_soon(self._on_exit, exitcode)
try:
self._ongoing_background_tasks.call_soon(self._on_exit, exitcode)
except AsyncTaskGroupClosedError: # Async task group has already been closed, so the nanny is already clos(ed|ing).
pass

@log_errors
async def _on_exit(self, exitcode):
Expand Down