-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_stress_creation_and_deletion #7215
Fix test_stress_creation_and_deletion #7215
Conversation
This reverts commit f8b84c0.
The assertion probably did make sense. We shouldn't assign tasks to non-running workers.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 26m 55s ⏱️ - 18m 52s For more details on these failures, see this check. Results for commit f34b72a. ± Comparison against base commit e0669cd. ♻️ This comment has been updated with latest results. |
Stress test (19x20 repeats) proves this is very stable now. |
Does this mean you ran it 19x20 = 380 times or 19 out of 20 successful runs? 🤔 |
380 times over all CI environments |
Correction: 2 out of 378 times it failed with
Both failures are concentrated in the same CI run which is suspicious. |
Merging tomorrow if nobody objects |
test_stress_creation_and_deletion
flaky #5388decide_worker_rootish_queuing_disabled
assertion fails when retiring worker #7063