Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_stress_creation_and_deletion #7215

Merged
merged 15 commits into from
Nov 3, 2022

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Oct 28, 2022

@crusaderky crusaderky self-assigned this Oct 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 26m 55s ⏱️ - 18m 52s
  3 161 tests ±0    3 075 ✔️  - 2    84 💤 +1  2 +1 
23 388 runs  ±0  22 482 ✔️  - 2  901 💤 +1  5 +1 

For more details on these failures, see this check.

Results for commit f34b72a. ± Comparison against base commit e0669cd.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky marked this pull request as ready for review October 28, 2022 12:31
@crusaderky
Copy link
Collaborator Author

Stress test (19x20 repeats) proves this is very stable now.

@fjetter
Copy link
Member

fjetter commented Oct 28, 2022

Stress test (19x20 repeats) proves this is very stable now.

Does this mean you ran it 19x20 = 380 times or 19 out of 20 successful runs? 🤔

@crusaderky
Copy link
Collaborator Author

Stress test (19x20 repeats) proves this is very stable now.

Does this mean you ran it 19x20 = 380 times or 19 out of 20 successful runs? thinking

380 times over all CI environments

@crusaderky
Copy link
Collaborator Author

crusaderky commented Oct 28, 2022

Correction: 2 out of 378 times it failed with

ERROR    asyncio:base_events.py:1707 Task was destroyed but it is pending!
task: <Task pending name='Task-121177' coro=<PeriodicCallback._run() running at /Users/runner/work/distributed/distributed/distributed/compatibility.py:157> cb=[IOLoop.add_future.<locals>.<lambda>() at /Users/runner/miniconda3/envs/dask-distributed/lib/python3.8/site-packages/tornado/ioloop.py:688]>

Both failures are concentrated in the same CI run which is suspicious.
The failure rate is below many other tests - I think we should merge.

@crusaderky
Copy link
Collaborator Author

Merging tomorrow if nobody objects

@crusaderky crusaderky merged commit 23f7cc0 into dask:main Nov 3, 2022
@crusaderky crusaderky deleted the test_stress_creation_and_deletion branch November 3, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_stress_creation_and_deletion flaky
3 participants