Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_stress_creation_and_deletion #7215

Merged
merged 15 commits into from
Nov 3, 2022
Merged

Fix test_stress_creation_and_deletion #7215

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
34c506a
Fix decide_worker_rootish_queuing_disabled assert
gjoseph92 Sep 23, 2022
86c26b0
Revert "Fix decide_worker_rootish_queuing_disabled assert"
gjoseph92 Oct 25, 2022
e318f47
Don't use last worker if it's not running
gjoseph92 Oct 25, 2022
3d33954
improve readability
gjoseph92 Oct 25, 2022
5ada8d4
test assertions on queuing
crusaderky Oct 27, 2022
a5bf663
Merge branch 'main' into fix-decide_worker_rootish_queuing_disabled-a…
crusaderky Oct 27, 2022
c815114
Merge branch 'queue-assert' into fix-decide_worker_rootish_queuing_di…
crusaderky Oct 27, 2022
5b7869c
tweak
crusaderky Oct 27, 2022
06fff7c
polish
crusaderky Oct 27, 2022
7eb4649
skip test when queuing is active
gjoseph92 Oct 27, 2022
d82d487
Fix flaky test_include_communication_in_occupancy
gjoseph92 Oct 27, 2022
5592da9
Merge branch 'main' into fix-decide_worker_rootish_queuing_disabled-a…
crusaderky Oct 28, 2022
9259519
Fix test_stress_creation_and_deletion
crusaderky Oct 28, 2022
8cc695b
Merge branch 'main' into test_stress_creation_and_deletion
crusaderky Oct 28, 2022
f34b72a
revert stress test
crusaderky Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions distributed/tests/test_stress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

from dask import delayed

from distributed import Client, Nanny, wait
from distributed import Client, Nanny, Worker, wait
from distributed.chaos import KillWorker
from distributed.compatibility import WINDOWS
from distributed.metrics import time
Expand Down Expand Up @@ -91,14 +91,10 @@ def test_cancel_stress_sync(loop):
c.cancel(f)


@pytest.mark.xfail(
reason="Flaky and re-fails on rerun. See https://github.com/dask/distributed/issues/5388"
)
@pytest.mark.slow
@gen_cluster(
nthreads=[],
client=True,
timeout=180,
scheduler_kwargs={"allowed_failures": 100_000},
)
async def test_stress_creation_and_deletion(c, s):
Expand All @@ -113,13 +109,12 @@ async def test_stress_creation_and_deletion(c, s):
async def create_and_destroy_worker(delay):
start = time()
while time() < start + 5:
async with Nanny(s.address, nthreads=2) as n:
async with Worker(s.address, nthreads=2) as n:
await asyncio.sleep(delay)
print("Killed nanny")

await asyncio.gather(*(create_and_destroy_worker(0.1 * i) for i in range(20)))

async with Nanny(s.address, nthreads=2):
async with Worker(s.address, nthreads=2):
assert await c.compute(z) == 8000884.93


Expand Down