This repository has been archived by the owner on Jan 25, 2018. It is now read-only.
Allow building and pushing images on another branch #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, all images are pushed with the SHA and the `latest` tag. With this commit, pushing an image will tag it with the branch name as well for easier use while developing. Unfortunately, k8s doesn't support templating yet (kubernetes/kubernetes#23896) so you'll still have to manually change the image tag in the `manifest.yaml` file back and forth but it's definitely easier than before. Now, the workflow is: 1. Work on image 2. Push with `make release-all` 3. Edit `manifest.yaml` to use images for your branch to test 4. Edit it back when making a PR.
Before, all images are pushed with the SHA and the `latest` tag. With this commit, pushing an image will tag it with the branch name as well for easier use while developing. Unfortunately, k8s doesn't support templating yet (kubernetes/kubernetes#23896) so you'll still have to manually change the image tag in the `manifest.yaml` file back and forth but it's definitely easier than before. Now, the workflow is: 1. Work on image 2. Push with `make release-all` 3. Edit `manifest.yaml` to use images for your branch to test 4. Edit it back when making a PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@derrickmar @SaladRaider @allanlwu @jiefugong
Before, all images are pushed with the SHA and the
latesttag.With this commit, pushing an image will tag it with the branch name as
well for easier use while developing.
Unfortunately, k8s doesn't support templating yet
(kubernetes/kubernetes#23896) so you'll still
have to manually change the image tag in the
manifest.yamlfile backand forth but it's definitely easier than before.
Now, the workflow is:
make release-allmanifest.yamlto use images for your branch to test