Skip to content
This repository has been archived by the owner on Jan 25, 2018. It is now read-only.

Allow building and pushing images on another branch #25

Merged
merged 5 commits into from
Nov 6, 2016
Merged

Allow building and pushing images on another branch #25

merged 5 commits into from
Nov 6, 2016

Commits on Nov 6, 2016

  1. Allow building and pushing images on another branch 

    Before, all images are pushed with the SHA and the `latest` tag.

With this commit, pushing an image will tag it with the branch name as
well for easier use while developing.

Unfortunately, k8s doesn't support templating yet
(kubernetes/kubernetes#23896) so you'll still
have to manually change the image tag in the `manifest.yaml` file back
and forth but it's definitely easier than before.

Now, the workflow is:

1. Work on image
2. Push with `make release-all`
3. Edit `manifest.yaml` to use images for your branch to test
4. Edit it back when making a PR.
    @SamLau95
    SamLau95 committed Nov 6, 2016
    Configuration menu
    Copy the full SHA
    fe9652d View commit details
    Browse the repository at this point in the history

  2. Allow building and pushing images on another branch 

    Before, all images are pushed with the SHA and the `latest` tag.

With this commit, pushing an image will tag it with the branch name as
well for easier use while developing.

Unfortunately, k8s doesn't support templating yet
(kubernetes/kubernetes#23896) so you'll still
have to manually change the image tag in the `manifest.yaml` file back
and forth but it's definitely easier than before.

Now, the workflow is:

1. Work on image
2. Push with `make release-all`
3. Edit `manifest.yaml` to use images for your branch to test
4. Edit it back when making a PR.
    @SamLau95
    SamLau95 committed Nov 6, 2016
    Configuration menu
    Copy the full SHA
    82ab71d View commit details
    Browse the repository at this point in the history

  3. Fix comment

    @SamLau95
    SamLau95 committed Nov 6, 2016
    Configuration menu
    Copy the full SHA
    121d38c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'build-branch' of github.com:data-8/jupyterhub-k8s into … 

    …build-branch
    @SamLau95
    SamLau95 committed Nov 6, 2016
    Configuration menu
    Copy the full SHA
    b58de29 View commit details
    Browse the repository at this point in the history

  5. Set branch properly in travis

    @SamLau95
    SamLau95 committed Nov 6, 2016
    Configuration menu
    Copy the full SHA
    08ce24f View commit details
    Browse the repository at this point in the history