Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex type promotion diagram disappears in the draft standard #477

Closed
leofang opened this issue Sep 11, 2022 · 1 comment · Fixed by #491
Closed

Complex type promotion diagram disappears in the draft standard #477

leofang opened this issue Sep 11, 2022 · 1 comment · Fixed by #491
Labels
Maintenance Bug fix, typo fix, or general maintenance. topic: Complex Data Types Complex number data types. topic: Type Promotion Type promotion.

Comments

@leofang
Copy link
Contributor

leofang commented Sep 11, 2022 •
edited
Loading

In the 2021.12 standard it is here: https://data-apis.org/array-api/2021.12/API_specification/data_types.html#float64, which says it "will be added to Type Promotion Rules". But it disappears in both Data Types and Type Promotion Rules sections of the draft standard. I think it was a simple overlook when creating the versioned standards.
@leofang leofang mentioned this issue Sep 11, 2022
Closed
@leofang leofang added topic: Complex Data Types Complex number data types. Maintenance Bug fix, typo fix, or general maintenance. labels Sep 11, 2022
@leofang
Copy link
Contributor Author

leofang commented Sep 22, 2022

According to @kgryte the plan is to merge https://github.com/data-apis/array-api/blob/main/spec/_static/images/dtype_promotion_complex.png into https://github.com/data-apis/array-api/blob/main/spec/_static/images/dtype_promotion_lattice.png.

rgommers added a commit to rgommers/array-api that referenced this issue Oct 6, 2022
@rgommers
Update type promotion rules for complex dtypes
3354312 
- Add a table with promotion rules
- Update type promotion lattice diagram

Closes data-apisgh-477
Closes data-apisgh-478
@rgommers rgommers mentioned this issue Oct 6, 2022
Merged
@rgommers rgommers added the topic: Type Promotion Type promotion. label Oct 7, 2022
@kgryte kgryte closed this as completed in aefec14 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance. topic: Complex Data Types Complex number data types. topic: Type Promotion Type promotion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update type promotion rules for complex dtypes rgommers/array-api
2 participants
@rgommers @leofang