Update type promotion rules for complex dtypes #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a table with promotion rules - Update type promotion lattice diagram Closes data-apisgh-477 Closes data-apisgh-478
|
Based on discussions on gh-478 and during the 22 September 2022 consortium meeting, we should update this PR to have a single floating-point table with both real and complex floating-point data types, as proposed by Leo (see #478 (comment)). TensorFlow's lack of real-complex dtype promotion was not considered a blocker. An increase in the number of kernels (i.e., implementations for specific dtype pairs) was also not considered a blocker. The number of kernels an array library chooses to implement is an implementation detail; from a user POV, the expectation is that mixed real-complex promotion should just work. |
|
Okay, this should be good to go now (please squash commits when merging). Apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-477
Closes gh-478
On gh-478, @leofang made a different suggestion regarding the actual rules (mixed-kind real/complex allowed), so let's discuss that there before merging this. Marking as draft for now.