Add specification for computing the number of non-zero singular values of a matrix (linalg: matrix_rank) #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Renamed |
rgommers
force-pushed
the
main
branch
3 times, most recently
from
0607525 to
138e963
Compare
|
This PR has been open for some time without further comment and has been discussed/approved during meetings. Will merge, and we can submit follow-up PRs should any issues/concerns arise. |
|
For reference, inclusion of this API was discussed here. |
rgommers
added a commit
to rgommers/array-api
that referenced
this pull request
Nov 16, 2022
This was a simple mistake, not discussed in the review for the PR that added `matrix_rank` (data-apisgh-128). Closes data-apisgh-469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
CuPy and Torch (
torch.matrix_rank) do not support providing stacks of matrices. Torch latestmasterdoes. This proposal follows NumPy and other linalg APIs in supporting stacks.Dask does not have a
matrix_rankAPI.NumPy, MXNet, Torch (latest
master) support ahermitiankeyword argument to indicate a potential optimization. This keyword argument is not widely supported and is not included in this proposal.Torch (latest
master), CuPy, and possibly TF only support specifyingtolas afloat. This PR follows NumPy and other API proposals (e.g.,pinvandlstsq) in allowingtolto be specified as either afloator anarrayof floats. Providing anarrayallows specifying one or more tolerances. This PR specifies tolerance asrtolto more explicitly indicate relative tolerance and to distinguish fromatol(absolute tolerance).TF supports a
validate_argskeyword argument. TF is alone in doing so, and such a keyword argument is not included in this proposal.