Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quicksight embedding has stopped working in 1.4.3 #400

Closed
manjulaK opened this issue Apr 3, 2023 · 0 comments · Fixed by #403
Closed

Quicksight embedding has stopped working in 1.4.3 #400

manjulaK opened this issue Apr 3, 2023 · 0 comments · Fixed by #403

Comments

@manjulaK
Copy link
Contributor

manjulaK commented Apr 3, 2023

Describe the bug

After testing we are seeing that QuickSight dashboards don't show up within data.all after being imported. This is even before sharing is enabled.

How to Reproduce

*P.S. Please do not attach files as it's considered a security risk. Add code snippets directly in the message body as much as possible.*

Expected behavior

QuickSight dashboards should show up within data.all after being imported.

Your project

No response

Screenshots

No response

OS

all

Python version

3.1

AWS data.all version

All

Additional context

No response
@dlpzx dlpzx mentioned this issue Apr 3, 2023
Merged
@dlpzx dlpzx linked a pull request Apr 3, 2023 that will close this issue
hotfix: Revert PR on custom url quicksight embedding sessions #403
Merged
@dlpzx dlpzx closed this as completed in #403 Apr 4, 2023
dlpzx added a commit that referenced this issue Apr 4, 2023
@dlpzx
hotfix: Revert PR on custom url quicksight embedding sessions (#403)
d191b26 
### Feature or Bugfix
- Bugfix

### Detail
In PR #380 domains that are not custom domains are not taken into
account. Reverting changes back and will continue that feature on the
side.

### Relates
- #400 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hotfix: Revert PR on custom url quicksight embedding sessions data-dot-all/dataall
1 participant
@manjulaK