Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Revert PR on custom url quicksight embedding sessions #403

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Apr 3, 2023

Feature or Bugfix

  • Bugfix

Detail

In PR #380 domains that are not custom domains are not taken into account. Reverting changes back and will continue that feature on the side.

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx linked an issue Apr 3, 2023 that may be closed by this pull request
@dlpzx dlpzx requested a review from noah-paige April 3, 2023 20:54
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dlpzx dlpzx merged commit d191b26 into main Apr 4, 2023
@dlpzx dlpzx deleted the reverting-quicksight-embedding-143 branch April 4, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quicksight embedding has stopped working in 1.4.3
2 participants