Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: disable profiling results view to secret datasets #478

Closed
dlpzx opened this issue May 24, 2023 · 1 comment
Closed

Feature request: disable profiling results view to secret datasets #478

dlpzx opened this issue May 24, 2023 · 1 comment
Labels
priority: high type: newfeature New feature request

Comments

@dlpzx
Copy link
Contributor

dlpzx commented May 24, 2023

Is your idea related to a problem? Please describe.
Since datasets preview is disabled for "secret" datasets it also seems logical to restrict the view of the profiling results.

Describe the solution you'd like
If a dataset has a confidentiality=secret, profiling results are not visible

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.
@dlpzx dlpzx added status: in-progress This issue has been picked and is being implemented type: newfeature New feature request priority: high labels May 24, 2023
@dlpzx dlpzx mentioned this issue May 26, 2023
Merged
@dlpzx dlpzx added status: in-review This issue has been implemented and is currently in review and waiting for next release and removed status: in-progress This issue has been picked and is being implemented labels May 30, 2023
dlpzx added a commit that referenced this issue Jun 2, 2023
@dlpzx
feat: Disabling profiling results from "secret" and "official" datase…
856a721 
…ts (#482)

### Feature or Bugfix
- Feature

### Detail
- For datasets that are classified as "Secret", data preview is
disabled. In the same way, data profiling results should alse be denied.
- Added tests for profiling
- removed unused methods

![image](https://github.com/awslabs/aws-dataall/assets/71252798/cc860476-b8ad-429f-ab2b-76c6f09f0010)

### Relates
- #478 
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@noah-paige noah-paige removed the status: in-review This issue has been implemented and is currently in review and waiting for next release label Jul 19, 2023
@noah-paige
Copy link
Contributor

Closing issue - implemented in v1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high type: newfeature New feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noah-paige @dlpzx