List possible values when inviting a team within an environment

[LEUNGUU]

Feature or Bugfix

• Feature

Detail

• Provide a drop down list of Cognito Groups for user to choose when inviting a team to an organization or an environment

Relates

• List and search for possible values when inviting a team within an environment #78

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[dlpzx]

As an additional step, we could filter the groups in the dropdown to list all cognito groups, minus the groups that have already been invited @LEUNGUU

[louishourcade]

Thanks for your PR @LEUNGUU,
Can you remove the console logs in EnvironmentTeamInviteForm.js ?
Also as @dlpzx mentioned, I think it would be nice to show only groups that do have access to he environment yet. Could you add this to the PR ?

[LEUNGUU]

Thanks for your PR @LEUNGUU, Can you remove the console logs in EnvironmentTeamInviteForm.js ? Also as @dlpzx mentioned, I think it would be nice to show only groups that do have access to he environment yet. Could you add this to the PR ?

Hi Louis. Sure. I will look into it.

[dlpzx]

Final remarks:

1. Environment and organization permissions. In the original implementation we used calls to the RDS DB that had been decorated and checked the permissions on the orga or environment. Now we do not check the permissions when listing the groups, but we still check the permissions when we invite the team. Therefore, we are not loosing control over the "invite" action.
2. We removed the integration tests on the list environment groups. This one I think it is important (and I will add a test in the PR). This api call is essential for the use of data.all. Without it teams cannot be added and work on the environment/orga

[dlpzx]

Hi @LEUNGUU, I have added the integration test for the api. For the integration test it was easier to move the cognito calls to the handlers (for mocking). I also like having all AWS boto3 calls in the handlers, even if they are calling services in the central infra account

[LEUNGUU]

@dlpzx Even though this 'list_cognito_groups' function is not so consistent with others in handlers folder, well, I agree with you. Let's put it there.

[dlpzx]

I tested the coverage integration tests and they succeded