Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with duplicate resources - backwards compatibility #416

Closed
wants to merge 5 commits into from
Closed

Fix issue with duplicate resources - backwards compatibility #416

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc3d154
Fix issue with duplicate resources - backwards compatibility
dlpzx Apr 18, 2023
11ddaff
Revert "Fix issue with duplicate resources - backwards compatibility"
dlpzx Apr 18, 2023
d87e421
Fix issue with duplicate resources(back to SageMaker in environment s…
dlpzx Apr 18, 2023
d928742
Remove unnecessary imports
dlpzx Apr 18, 2023
9604333
Fix issue with duplicate resources(fix testing) - backwards compatibi…
dlpzx Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backend/dataall/cdkproxy/stacks/sagemakerstudio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def check_existing_sagemaker_studio_domain(self, environment: models.Environment
)
dataall_created_domain = ParameterStoreManager.client(
AwsAccountId=environment.AwsAccountId, region=environment.region, role=cdk_look_up_role_arn
).get_parameter(Name=f'/dataall/{environment.environmentUri}/sagemaker/sagemakerstudio/domain_id')
).get_parameter(Name=f'/dataall/{environment.environmentUri}/sagemaker/sagemakerstudio/domainId')
return False
except ClientError as e:
logger.info(f'check sagemaker studio domain created outside of data.all. Parameter data.all not found: {e}')
Expand All @@ -62,7 +62,7 @@ def __init__(self, scope: Construct, construct_id: str, environment: models.Envi
self,
'RoleForSagemakerStudioUsers',
assumed_by=iam.ServicePrincipal('sagemaker.amazonaws.com'),
role_name='RoleSagemakerStudioUsers',
role_name='RoleForSagemakerStudioUsers',
managed_policies=[
iam.ManagedPolicy.from_managed_policy_arn(
self,
Expand Down Expand Up @@ -117,7 +117,7 @@ def __init__(self, scope: Construct, construct_id: str, environment: models.Envi
self,
'SagemakerStudioDomainId',
string_value=sagemaker_domain.attr_domain_id,
parameter_name=f'/dataall/{self._environment.environmentUri}/sagemaker/sagemakerstudio/domain_id',
parameter_name=f'/dataall/{self._environment.environmentUri}/sagemaker/sagemakerstudio/domainId',
)


Expand Down