Fix issue with duplicate resources - backwards compatibility

[dlpzx]

Feature or Bugfix

• Bugfix

Detail

• In v1.5.0 SageMaker Studio base infra is moved out in a nested stack. As a consequence sometimes there are conflicts with already existing AWS resources that the nested stack is trying to re-create. But the issue is bigger than that, the new nested stack would create a new Sagemaker domain and delete the previous one. If there are existing Sagemaker studio users this results in errors because it cannot delete a domain with existing users. We have 2 alternatives: 1) migrate existing users to the new profile 2) revert the changes and put the Sagemaker resources inside the environment stack, this will keep the previous resources.

Alternative 1 is quite complex (and I am not sure it is even possible). The benefit that it brings, which is "logical separation of environment-module resources" is not worth the effort.

Relates

#409

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[nikpodsh]

Why should we delete SageMakerDomain ? If we decided not to go with the nested stack and rollback it, I'd still leave this class, remove only NestedStack, changed init to create_ml_studio_part` (or something like that) and keep using it :)

[dlpzx]

I think I am going to start clean in another branch with your ideas, with no rush. Thanks @nikpodsh