Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-devtools-core from 4.28.0 to 4.28.4 in /frontend #824

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2023

Bumps react-devtools-core from 4.28.0 to 4.28.4.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [react-devtools-core](https://github.com/facebook/react/tree/HEAD/packages/react-devtools-core) from 4.28.0 to 4.28.4.
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/HEAD/packages/react-devtools-core)

---
updated-dependencies:
- dependency-name: react-devtools-core
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 21, 2023
@dlpzx
Copy link
Contributor

dlpzx commented Oct 26, 2023

@noah-paige I have had a look at the package.json and the yarn.lock and I am a bit confused because the package updated only appears in the package-lock.json and not in yarn.lock. It is a sub-dependency but I am not sure how is it used.

@mkhidir-aws
Copy link

@noah-paige I have had a look at the package.json and the yarn.lock and I am a bit confused because the package updated only appears in the package-lock.json and not in yarn.lock. It is a sub-dependency but I am not sure how is it used.

@dlpzx @noah-paige I checked, the updated package react-devtools-core is not available in yarn, so the update doesn't apply to yarn.lock. I think we can merge this.

Copy link

@mkhidir-aws mkhidir-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this. react-devtools-core is not available in yarn, so there is no need for an update.

@noah-paige
Copy link
Contributor

Testing a deployment in AWS to ensure frontend still accessible - will approve and merge if all looks good

Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed changes and frontend seems unaffected - approving

@noah-paige noah-paige merged commit b60dab8 into main Nov 1, 2023
8 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/frontend/react-devtools-core-4.28.4 branch November 1, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants