feat: List catalogs from metasrv #12219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
pr-feature
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
zhang2014
approved these changes
Jul 27, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
Ok, most test caes passed. The only missing piece is |
|
After this pull request, our multi-catalog feature is now available! Users can create, list, show and drop catalogs that will be saved by Databend in Metasrv. At current stage, we support |
|
Can't not reproduce locally: Test finished, fail fast enabled, 1 out of 4102 records failed to run
0: query result mismatch:
[SQL] SHOW CATALOGS LIKE 'ctl';
[Diff] (-expected|+actual)
- ctl
Error: SelfError("sqllogictest failed")
at tests/sqllogictests/suites/base/05_ddl/05_0029_ddl_create_catalog:12I'm working on it. |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
This reverts commit 9c11187.
|
Let's go! |
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
* feat: List catalogs from metasrv Signed-off-by: Xuanwo <github@xuanwo.io> * try move Signed-off-by: Xuanwo <github@xuanwo.io> * Revert "try move" This reverts commit d524d4d. * Revert "feat: List catalogs from metasrv" This reverts commit ec9939f. * Add meta-store Signed-off-by: Xuanwo <github@xuanwo.io> * Add config Signed-off-by: Xuanwo <github@xuanwo.io> * Save work Signed-off-by: Xuanwo <github@xuanwo.io> * Fix build Signed-off-by: Xuanwo <github@xuanwo.io> * Fix typos Signed-off-by: Xuanwo <github@xuanwo.io> * format toml Signed-off-by: Xuanwo <github@xuanwo.io> * Implement list_catalogs Signed-off-by: Xuanwo <github@xuanwo.io> * Implement create catalog Signed-off-by: Xuanwo <github@xuanwo.io> * Fix build Signed-off-by: Xuanwo <github@xuanwo.io> * Fix test Signed-off-by: Xuanwo <github@xuanwo.io> * Fix test Signed-off-by: Xuanwo <github@xuanwo.io> * Refactor Signed-off-by: Xuanwo <github@xuanwo.io> * fix cargo lock Signed-off-by: Xuanwo <github@xuanwo.io> * Save work Signed-off-by: Xuanwo <github@xuanwo.io> * Add catalog info in plan Signed-off-by: Xuanwo <github@xuanwo.io> * Fix build Signed-off-by: Xuanwo <github@xuanwo.io> * Fix test Signed-off-by: Xuanwo <github@xuanwo.io> * Fix test Signed-off-by: Xuanwo <github@xuanwo.io> * Use debug for test Signed-off-by: Xuanwo <github@xuanwo.io> * Fix tenant Signed-off-by: Xuanwo <github@xuanwo.io> * fix test Signed-off-by: Xuanwo <github@xuanwo.io> * Revert "Use debug for test" This reverts commit 9c11187. --------- Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
This PR will allow list catalogs from metasrv.
This change is