Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add drop catalog support for metasrv #12248

Merged
merged 4 commits into from
Jul 29, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 29, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

This PR will add drop catalog support at metasrv side.

Part of #12219


This change is Reviewable

Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented Jul 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2023 1:49pm

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 29, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from drmingdrmer and zhyass July 29, 2023 04:47
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @zhyass)

@BohuTANG
Copy link
Member

We have merged the minitrace PR with high priority, which has resulted in some conflicts :)

Signed-off-by: Xuanwo <github@xuanwo.io>
@BohuTANG BohuTANG merged commit 397493b into databendlabs:main Jul 29, 2023
@Xuanwo Xuanwo deleted the drop-catalog-meta branch July 29, 2023 17:32
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* feat: Add drop catalog support for metasrv

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix typo

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix build

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants