Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): Pass ci Test when enable enable_experimental_aggregate_hashtable . #14544

Merged
merged 11 commits into from
Feb 20, 2024
Merged

fix(query): Pass ci Test when enable enable_experimental_aggregate_hashtable . #14544

merged 11 commits into from
Feb 20, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Feb 1, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Pass ci Test when enable enable_experimental_aggregate_hashtable .

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li added the ci-benchmark Benchmark: run all test label Feb 1, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 1, 2024
@sundy-li sundy-li changed the title chore(query): test-perf chore(query): test-perf for enable_experimental_aggregate_hashtable = 1 Feb 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Docker Image for PR

  • tag: pr-14544-c0dfb1a

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

cloud cloud

ClickBench Report

@sundy-li
Copy link
Member Author

sundy-li commented Feb 1, 2024

hits got improvements:

image

@sundy-li sundy-li closed this Feb 1, 2024
@sundy-li sundy-li reopened this Feb 18, 2024
@sundy-li sundy-li removed the ci-benchmark Benchmark: run all test label Feb 18, 2024
@sundy-li sundy-li mentioned this pull request Feb 19, 2024
Closed
11 tasks
@sundy-li sundy-li changed the title chore(query): test-perf for enable_experimental_aggregate_hashtable = 1 fix(query): Pass ci Test when enable enable_experimental_aggregate_hashtable . Feb 19, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Feb 19, 2024
@sundy-li sundy-li marked this pull request as ready for review February 19, 2024 07:00
@sundy-li sundy-li added this pull request to the merge queue Feb 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2024
@sundy-li sundy-li added this pull request to the merge queue Feb 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2024
@sundy-li
fix(query): Pass ci Test when enable `enable_experimental_aggregate_h…
9c35735 
…ashtable `. (#14544)

* test-perf

* fix

* fix

* fix

* fix decimal

* fix decimal

* fix decimal

* revert settings
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2024
@sundy-li sundy-li added this pull request to the merge queue Feb 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2024
@sundy-li
Copy link
Member Author

sundy-li commented Feb 20, 2024 •
edited
Loading

@BohuTANG This could be merged, it tests with enable_experimental_aggregate_hashtable .

Some bugs are fixed and revert the setting.

@BohuTANG BohuTANG merged commit 3340c38 into databendlabs:main Feb 20, 2024
73 checks passed
yufan022 pushed a commit to yufan022/databend that referenced this pull request Jun 18, 2024
@sundy-li @yufan022
fix(query): Pass ci Test when enable `enable_experimental_aggregate_h…
3840f2e 
…ashtable `. (databendlabs#14544)
yufan022 pushed a commit to yufan022/databend that referenced this pull request Jun 18, 2024
@sundy-li @yufan022
fix(query): Pass ci Test when enable `enable_experimental_aggregate_h…
0e4be57 
…ashtable `. (databendlabs#14544)

* test-perf

* fix

* fix

* fix

* fix decimal

* fix decimal

* fix decimal

* revert settings

(cherry picked from commit 3340c38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freejww Freejww Freejww approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundy-li @Freejww @BohuTANG