Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix incorrect agg spill in new agg hashtable #14993

Closed
wants to merge 3 commits into from

Conversation

Freejww
Copy link
Contributor

@Freejww Freejww commented Mar 18, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

In PR #14905, we add spill for new agg hashtable ,but we found data loss caused by incorrect handling. this pr fix it by normalizing the data.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@Freejww Freejww changed the title fix:incorrect agg spill in new agg hashtable fix(query):incorrect agg spill in new agg hashtable Mar 18, 2024
@Freejww Freejww changed the title fix(query):incorrect agg spill in new agg hashtable chore(query):incorrect agg spill in new agg hashtable Mar 18, 2024
@databendlabs databendlabs deleted a comment from github-actions bot Mar 18, 2024
@Freejww Freejww changed the title chore(query):incorrect agg spill in new agg hashtable fix(query):fix incorrect agg spill in new agg hashtable Mar 18, 2024
@Freejww Freejww changed the title fix(query):fix incorrect agg spill in new agg hashtable fix(query): fix incorrect agg spill in new agg hashtable Mar 18, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 18, 2024
@BohuTANG
Copy link
Member

We need more agg spill tests to avoid this.

@Freejww Freejww closed this Mar 18, 2024
@Freejww Freejww deleted the fix/agg_spill branch March 18, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants