feat(query): support spill for new agg hashtable #14905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 8, 2024 12:04
github-actions
bot
added
the
pr-feature
|
Please make each commit is meaningful, not a |
BohuTANG
reviewed
Mar 11, 2024
|
Let me make sure one thing, the agg hash table won't be used for join, right? |
It uses for group_by |
Right. |
zhang2014
reviewed
Mar 12, 2024
zhang2014
reviewed
Mar 12, 2024
src/query/service/src/pipelines/processors/transforms/aggregator/aggregate_meta.rs
Outdated
Show resolved
Hide resolved
…or/aggregate_meta.rs Co-authored-by: Winter Zhang <coswde@gmail.com>
sundy-li
reviewed
Mar 13, 2024
sundy-li
approved these changes
Mar 13, 2024
This was referenced Mar 18, 2024
yufan022
pushed a commit
to yufan022/databend
that referenced
this pull request
Jun 18, 2024
yufan022
pushed a commit
to yufan022/databend
that referenced
this pull request
Jun 18, 2024
* test * test * finish singleton spill * cluster spill * Update src/query/service/src/pipelines/processors/transforms/aggregator/aggregate_meta.rs Co-authored-by: Winter Zhang <coswde@gmail.com> * add Result<> for func return type * fix bug * fix decimal bug * remove output columns(AggregatePartial) to pass ci * revert set --------- Co-authored-by: jw <freejw@gmail.com> Co-authored-by: Winter Zhang <coswde@gmail.com> (cherry picked from commit 31e9ad0)
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
In the previous PR #14798, we support new agg hashtable on cluster. In this PR, we support spill for new agg hashtable on singleton and cluster.
Note:
The setting
enable_experimental_aggregate_hashtable=1is temporary. Once the CI tests pass, we will change it to false before merging.Tests
Type of change
This change is