fix: fix incorrect agg spill in new agg hashtable #14995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundy-li
reviewed
Mar 18, 2024
src/query/service/src/pipelines/processors/transforms/aggregator/transform_partition_bucket.rs
Show resolved
Hide resolved
sundy-li
reviewed
Mar 18, 2024
sundy-li
reviewed
Mar 18, 2024
sundy-li
approved these changes
Mar 19, 2024
Docker Image for PR
|
yufan022
pushed a commit
to yufan022/databend
that referenced
this pull request
Jun 18, 2024
* fix agg spill * fix agg spill --------- Co-authored-by: jw <freejw@gmail.com>
yufan022
pushed a commit
to yufan022/databend
that referenced
this pull request
Jun 18, 2024
* fix agg spill * fix agg spill --------- Co-authored-by: jw <freejw@gmail.com> (cherry picked from commit 7171319)
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
In PR #14905, we add spill for new agg hashtable ,but we found data loss caused by incorrect handling. this pr fix it by normalizing the data. We will add more spill tests in future.
Tests
Type of change