Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): improve group #15031

Merged
merged 14 commits into from
Mar 21, 2024
Merged

chore(query): improve group #15031

merged 14 commits into from
Mar 21, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Mar 20, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Reduce excessive probe in final aggregation stage.
  2. Fix TransformExchangeAggregateSerializer did not serialize all data from iterator

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 20, 2024
@sundy-li sundy-li changed the title chore: improve group chore(query): improve group Mar 20, 2024
@sundy-li sundy-li added the ci-cloud Build docker image for cloud test label Mar 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-15031-50ef73f

note: this image tag is only available for internal use,
please check the internal doc for more details.

@sundy-li sundy-li removed the ci-cloud Build docker image for cloud test label Mar 20, 2024
@sundy-li
Copy link
Member Author

It's hard to add tests for #15049 in ci.
We need a long run test to cover #15049

@sundy-li sundy-li marked this pull request as ready for review March 21, 2024 01:05
@sundy-li sundy-li requested a review from zhang2014 March 21, 2024 01:37
@BohuTANG BohuTANG merged commit bcee197 into databendlabs:main Mar 21, 2024
72 checks passed
yufan022 pushed a commit to yufan022/databend that referenced this pull request Jun 18, 2024
@sundy-li @yufan022
chore(query): improve group (databendlabs#15031)
c50afee 
* chore: improve group

* reduce serializer overhead

* reduce serializer overhead

* add limit optimize

* fix exchange bug

* fix exchange bug

* fix exchange bug

* fix exchange bug

* fix exchange bug

* update

* update
yufan022 pushed a commit to yufan022/databend that referenced this pull request Jun 18, 2024
@sundy-li @yufan022
chore(query): improve group (databendlabs#15031)
6a48fa3 
* chore: improve group

* reduce serializer overhead

* reduce serializer overhead

* add limit optimize

* fix exchange bug

* fix exchange bug

* fix exchange bug

* fix exchange bug

* fix exchange bug

* update

* update

(cherry picked from commit bcee197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: TransformExchangeAggregateSerializer did not serialize all data from iterator
3 participants
@sundy-li @zhang2014 @BohuTANG