Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Delete From #4228

Closed
wants to merge 7 commits into from
Closed

Feature: Delete From #4228

wants to merge 7 commits into from

Conversation

dantengsky
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

WIP: Statement "delete from"

Changelog

  • New Feature
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Feb 23, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/Dad49VrPQPgkK7HZYCPVfYszoJGb
✅ Preview: Canceled

[Deployment for 6c35cd8 canceled]

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-feature this PR introduces a new feature to the codebase pr-not-for-changelog labels Feb 23, 2022
sundy-li
sundy-li reviewed Feb 24, 2022
View reviewed changes
query/src/storages/fuse/operations/delete_from.rs
}

let new_snapshot = self.merge_segments(&segments_kept, &segments_new);
self.commit_deletion(new_snapshot).await?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So deletion will block inserts & updates?

Copy link
Member Author

@dantengsky dantengsky Feb 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deletion does not block other mutations. In this pr, a rather simple rule will be applied: when there are deletion-write conflicts, first-committer-win.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So continuous small inserts will cause the heavy deletion retry ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So continuous small inserts will cause the heavy deletion retry ...

er... too awkward... to catch this message months later.

  • yes, OCC implies the possibility of retrying
  • deletion might be heavy, but the retrying of deletion might not be

@BohuTANG BohuTANG mentioned this pull request Mar 27, 2022
Closed
55 tasks
@BohuTANG BohuTANG mentioned this pull request May 4, 2022
Closed
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
@dantengsky
Copy link
Member Author

transfered to PR #5691

@dantengsky dantengsky closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li left review comments

Assignees
No one assigned
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@dantengsky @sundy-li @Xuanwo @databend-bot