Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: statement delete from... #5691

Merged
merged 43 commits into from
Jun 27, 2022
Merged

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented May 30, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Simple delete statement (preview edition)
    DELETE FROM table WHERE ...
mysql> -- both planners v0/v1 are supported
mysql> create table t as select * from numbers(10);
Query OK, 0 rows affected (0.08 sec)

mysql> delete from t where number % 2 = 0;
Query OK, 0 rows affected (0.05 sec)

mysql>
mysql> select * from t;
+--------+
| number |
+--------+
|      1 |
|      3 |
|      5 |
|      7 |
|      9 |
+--------+
5 rows in set (0.03 sec)
Read 5 rows, 40.00 B in 0.005 sec., 978.99 rows/sec., 7.65 **KiB/sec.**
  • Main known limitations
    • USING clause is not supported yet
    • Non-distributed execution
    • no conflicts resolution yet
      in the case of mutation conflicts, the delete operation will abort

Changelog

  • New Feature
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #5146

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 27, 2022 at 9:20AM (UTC)

@dantengsky dantengsky mentioned this pull request May 30, 2022
@mergify
Copy link
Contributor

mergify bot commented May 30, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-feature this PR introduces a new feature to the codebase pr-not-for-changelog labels May 30, 2022
@BohuTANG BohuTANG mentioned this pull request Jun 5, 2022
55 tasks
@dantengsky dantengsky marked this pull request as ready for review June 27, 2022 07:15
@BohuTANG BohuTANG requested review from zhang2014 and removed request for wubx June 27, 2022 07:54
dantengsky and others added 2 commits June 27, 2022 16:53
Co-authored-by: Winter Zhang <coswde@gmail.com>
@BohuTANG BohuTANG merged commit 43ffa8b into databendlabs:main Jun 27, 2022
@BohuTANG
Copy link
Member

cc @soyeric128 for documentation

@soyeric128
Copy link
Collaborator

cc @soyeric128 for documentation

Please review this PR for doc updates: #6260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DELETE statement
6 participants