Change: remove defensive check utilities #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most defensive checks are replaced with `debug_assert!` embedded in Engine. `StoreExt` as a `RaftStorage` wrapper that implements defensive checks are no longer needed. `StoreExt` are mainly used for testing and it is very slow so that can not be used in production. - Remove structs: `StoreExt`, `DefensiveStoreBuilder` - Remove traits: `Wrapper`, `DefensiveCheckBase`, `DefensiveCheck`,
… log entry This bug causes replication tries to send pruged log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Change: remove defensive check utilities
Most defensive checks are replaced with
debug_assert!embedded in Engine.StoreExtas aRaftStoragewrapper that implements defensive checksare no longer needed.
StoreExtare mainly used for testing and it isvery slow so that can not be used in production.
StoreExt,DefensiveStoreBuilderWrapper,DefensiveCheckBase,DefensiveCheck,This change is