Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: remove defensive check utilities #761

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Change: remove defensive check utilities #761

merged 2 commits into from
Apr 11, 2023

Commits on Apr 11, 2023

  1. Change: remove defensive check utilities 

    Most defensive checks are replaced with `debug_assert!` embedded in Engine.
`StoreExt` as a `RaftStorage` wrapper that implements defensive checks
are no longer needed. `StoreExt` are mainly used for testing and it is
very slow so that can not be used in production.

- Remove structs: `StoreExt`, `DefensiveStoreBuilder`
- Remove traits: `Wrapper`, `DefensiveCheckBase`, `DefensiveCheck`,
    @drmingdrmer
    drmingdrmer committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    88f947a View commit details
    Browse the repository at this point in the history

  2. Fix: ProgressEntry::is_log_range_inflight() checks a log range, not a… 

    … log entry

This bug causes replication tries to send pruged log.
    @drmingdrmer
    drmingdrmer committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    26dc883 View commit details
    Browse the repository at this point in the history