-
Notifications
You must be signed in to change notification settings - Fork 128
Add support for configuring app.yaml options for apps via bundle config #4271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Commit: 17f9fb5
30 interesting tests: 15 RECOVERED, 10 KNOWN, 4 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
| @@ -0,0 +1,6 @@ | |||
| Local = false | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have it on testserver as well? Cloud-only tests are painful to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a relatively useless test, as here we are confirming backend behaviour that it overwrites values in app.yaml with whatever is passed to the Deploy call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. However, even if test itself is not useful, having local run means we can regenerate the output quickly with 'make test-update'.
The longer running 'make test-update-aws' skips tests that have Local=true.
Ideally, we are able to update all test output with local runs.
fjakobs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it!
|
Commit: c75194b
33 interesting tests: 17 RECOVERED, 9 flaky, 6 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
## Release v0.283.0 ### Notable Changes * Bundle commands now cache the user's account details to improve command latency. To disable this, set the environment variable DATABRICKS_CACHE_ENABLED to false. ### CLI * Add commands to pipelines command group ([#4275](#4275)) ### Bundles * Add support for configuring app.yaml options for apps via bundle config ([#4271](#4271)) * Enable caching user identity by default ([#4202](#4202)) * Do not show single node warning when is_single_node option is explicitly set ([#4272](#4272)) * Fix false positive folder permission warnings and make them more actionable ([#4216](#4216)) * Pass additional Azure DevOps system variables ([#4236](#4236)) * Replace Black formatter with Ruff in Python bundle templates for faster, all-in-one linting and formatting ([#4196](#4196)) * engine/direct: support quality monitors ([#4278](#4278)) * Improve folder permissions warning ([#4216](#4216)) ### Dependency updates * Upgrade TF provider to 1.102.0 ([#4235](#4235)) * Upgrade Go SDK to 0.96.0 ([#4206](#4206))
Changes
Add support for configuring app.yaml options for apps via bundle config
This change uses new fields from Apps.Deploy call:
CommandandEnvVars.Why
This change allows users to configure their Databricks Apps differently for different targets
Fixes #3679
Tests
Added an acceptance test