Do not show single node warning when is_single_node option is explicitly set #4272
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 182dd4d
26 interesting tests: 14 RECOVERED, 10 KNOWN, 1 SKIP, 1 flaky
Top 50 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Jan 13, 2026
denik
approved these changes
Jan 13, 2026
|
|
||
| diags := bundle.Apply(ctx, b, SingleNodeCluster()) | ||
| assert.Empty(t, diags) | ||
| } |
Contributor
There was a problem hiding this comment.
acceptance test in acceptance/bundle/validate would be a bit simpler, no?
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 751b1d3
42 interesting tests: 16 flaky, 15 RECOVERED, 10 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Jan 14, 2026
## Release v0.283.0 ### Notable Changes * Bundle commands now cache the user's account details to improve command latency. To disable this, set the environment variable DATABRICKS_CACHE_ENABLED to false. ### CLI * Add commands to pipelines command group ([#4275](#4275)) ### Bundles * Add support for configuring app.yaml options for apps via bundle config ([#4271](#4271)) * Enable caching user identity by default ([#4202](#4202)) * Do not show single node warning when is_single_node option is explicitly set ([#4272](#4272)) * Fix false positive folder permission warnings and make them more actionable ([#4216](#4216)) * Pass additional Azure DevOps system variables ([#4236](#4236)) * Replace Black formatter with Ruff in Python bundle templates for faster, all-in-one linting and formatting ([#4196](#4196)) * engine/direct: support quality monitors ([#4278](#4278)) * Improve folder permissions warning ([#4216](#4216)) ### Dependency updates * Upgrade TF provider to 1.102.0 ([#4235](#4235)) * Upgrade Go SDK to 0.96.0 ([#4206](#4206))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Do not show single node warning when is_single_node option is explicitly set
Why
Fixes #4267
Tests
Added an unit test