[PLAT-24515] - Remove Case sensitive option for create-scope in secrets #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=========================================
Coverage ? 84.55%
=========================================
Files ? 39
Lines ? 2726
Branches ? 0
=========================================
Hits ? 2305
Misses ? 421
Partials ? 0
Continue to review full report at Codecov.
|
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case sensitive option is not supported by the version of click that databricks_cli uses, so removing this option. After testing the commands with this change, since options for scope backend type are uppercase (DATBRICKS, AZURE_KEYVAULT), the arguments are still case sensitive. But the explicit case sensitive option is being removed to conform with current click version.