Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimal version of click to 7.0 #349

Closed
wants to merge 1 commit into from

Conversation

bgreenwell
Copy link

Patch to fix issue #348 regarding incorrect minimal version of click.

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #349 (bb730e9) into master (c4a5b91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files          39       39           
  Lines        2726     2726           
=======================================
  Hits         2305     2305           
  Misses        421      421           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a5b91...bb730e9. Read the comment docs.

@pietern
Copy link
Contributor

pietern commented Jul 1, 2022

Belated thanks for making the fix and posting a PR. We're slowly making our way through the backlog this past month.

The case_sensitive argument was removed in #347.

However, in the mean time we merged #471 which depends on click >= 7.0 for a different reason.

@pietern pietern closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants