Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unity Catalog support #471

Merged
merged 14 commits into from
Jun 17, 2022
Merged

Add Unity Catalog support #471

merged 14 commits into from
Jun 17, 2022

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jun 10, 2022

Changes w.r.t. #414:

  • Hide existing commands of the form verb-noun (but keep them around for backward compatibility)
  • Register commands grouped by entity, to support calling them as noun verb
  • Documentation related changes (docstrings and --help output)

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #471 (e730dd9) into main (dd24afa) will decrease coverage by 24.37%.
The diff coverage is 1.04%.

@@             Coverage Diff             @@
##             main     #471       +/-   ##
===========================================
- Coverage   85.22%   60.85%   -24.38%     
===========================================
  Files          42       55       +13     
  Lines        3270     4629     +1359     
===========================================
+ Hits         2787     2817       +30     
- Misses        483     1812     +1329     
Impacted Files Coverage Δ
databricks_cli/cli.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/api.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/catalog_cli.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/cli.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/cred_cli.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/delta_sharing_cli.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/ext_loc_cli.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/lineage_cli.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/metastore_cli.py 0.00% <0.00%> (ø)
databricks_cli/unity_catalog/perms_cli.py 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd24afa...e730dd9. Read the comment docs.

Copy link
Contributor

@adamcain-db adamcain-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I compared this branch against the latest master in databricks-cli-private and found no issues. I tried out the new command structure and it looks very good.
Thanks much for this work!

examples/unity_catalog/create-table1.json Outdated Show resolved Hide resolved
@pietern
Copy link
Contributor Author

pietern commented Jun 16, 2022

Incorporated a comment from @deka108 in #414 to provide a consistent --help output for --json and --json-file.

Difference introduced by 3766079: https://gist.github.com/pietern/f3bb9002b23f6cc714a561196e477e10

@pietern pietern requested a review from fjakobs June 16, 2022 12:51
@pietern pietern merged commit bccbdea into databricks:main Jun 17, 2022
@pietern pietern deleted the uc branch June 17, 2022 13:06
@adamcain-db
Copy link
Contributor

@pietern: I just noticed that the files from tests/lineages were not added (see PR in databricks-cli-private repo).

@pietern
Copy link
Contributor Author

pietern commented Jun 20, 2022

@LuShuai Could you port these over?

@adamcain-db
Copy link
Contributor

@LuShuai Could you port these over?

Added in PR #538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants