Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing UC lineage tests #538

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

adamcain-db
Copy link
Contributor

Add back the lineage tests that were omitted when the unity-catalog commands were added in #471.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2022

Codecov Report

Merging #538 (3d7d224) into main (1ef6bcb) will increase coverage by 4.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
+ Coverage   60.29%   64.79%   +4.50%     
==========================================
  Files          55       55              
  Lines        4727     4727              
==========================================
+ Hits         2850     3063     +213     
+ Misses       1877     1664     -213     
Impacted Files Coverage Δ
databricks_cli/utils.py 89.58% <0.00%> (+3.12%) ⬆️
databricks_cli/unity_catalog/uc_service.py 27.73% <0.00%> (+27.73%) ⬆️
databricks_cli/unity_catalog/utils.py 30.76% <0.00%> (+30.76%) ⬆️
databricks_cli/unity_catalog/api.py 47.97% <0.00%> (+47.97%) ⬆️
databricks_cli/unity_catalog/lineage_cli.py 80.00% <0.00%> (+80.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pietern
Copy link
Contributor

pietern commented Aug 15, 2022

Thanks, @adamcain-db . Could you move this over to a unity_catalog directory for parity with the CLI tree.

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamcain-db !

@pietern pietern merged commit e2338b3 into databricks:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants