Remove dead code from apierr/errors.go #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 41.82% 34.76% -7.06%
==========================================
Files 50 50
Lines 2788 3538 +750
==========================================
+ Hits 1166 1230 +64
- Misses 1518 2197 +679
- Partials 104 111 +7 see 36 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
tanmay-db
approved these changes
May 1, 2023
nfx
approved these changes
May 5, 2023
Merged
nfx
added a commit
that referenced
this pull request
May 11, 2023
# Version changelog ## 0.8.1 * Added `in` codegen function ([#387](#387)). * Fixed mlflow acceptance tests ([#378](#378)). * Fixed MLflow integration test and removed workaround for `DELETE` query parameter ([#380](#380)). * Make clusters acceptance tests robust to duplicate cluster names ([#381](#381)). * Remove dead code from apierr/errors.go ([#376](#376)). * Serialize params to request body on delete ([#383](#383)). Dependency updates: * Bump golang.org/x/oauth2 from 0.7.0 to 0.8.0 ([#385](#385)). * Bump google.golang.org/api from 0.118.0 to 0.122.0 ([#382](#382), [#386](#386)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove commented code from the error retry pathway. This is no longer needed and isn't included in any other SDKs.
Tests
make testpassingmake fmtapplied