Fixed MLflow integration test and removed workaround for DELETE query parameter
#380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
=======================================
Coverage 34.74% 34.74%
=======================================
Files 50 50
Lines 3540 3540
=======================================
Hits 1230 1230
Misses 2199 2199
Partials 111 111 ☔ View full report in Codecov by Sentry. |
tanmay-db
changed the title
DELETE
tanmay-db
changed the title
DELETEDELETE query parameter
kartikgupta-db
requested changes
May 2, 2023
Comment on lines
+142
to
+159
| startTime := time.Now() | ||
| for { | ||
| currentModelVersion, err := w.ModelRegistry.GetModelVersion(ctx, ml.GetModelVersionRequest{ | ||
| Name: created.ModelVersion.Name, | ||
| Version: created.ModelVersion.Version, | ||
| }) | ||
| require.NoError(t, err) | ||
|
|
||
| if currentModelVersion.ModelVersion.Status != ml.ModelVersionStatusPendingRegistration { | ||
| break | ||
| } | ||
| currentTime := time.Now() | ||
| elapsedTime := currentTime.Sub(startTime).Seconds() | ||
| if elapsedTime > 10 { | ||
| t.Fatalf("Timeout: Model version still has PENDING_REGISTERATION status after 10 seconds") | ||
| } | ||
| time.Sleep(2 * time.Second) | ||
| } |
There was a problem hiding this comment.
You might be able to use something like this https://stackoverflow.com/a/52218264 here, instead of manually keeping track of time.
There was a problem hiding this comment.
discussed offline - tldr - not able to use testing methods through goroutine -- might require passing messages to channel and read them from the testMethod and call test fail (after checking the channel to see if message is returned) but maybe not worth it.
kartikgupta-db
approved these changes
May 2, 2023
mgyucht
approved these changes
May 2, 2023
Merged
nfx
added a commit
that referenced
this pull request
May 11, 2023
# Version changelog ## 0.8.1 * Added `in` codegen function ([#387](#387)). * Fixed mlflow acceptance tests ([#378](#378)). * Fixed MLflow integration test and removed workaround for `DELETE` query parameter ([#380](#380)). * Make clusters acceptance tests robust to duplicate cluster names ([#381](#381)). * Remove dead code from apierr/errors.go ([#376](#376)). * Serialize params to request body on delete ([#383](#383)). Dependency updates: * Bump golang.org/x/oauth2 from 0.7.0 to 0.8.0 ([#385](#385)). * Bump google.golang.org/api from 0.118.0 to 0.122.0 ([#382](#382), [#386](#386)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Ran integration test on PR:
Verified query parameters are supported for MLflow DELETE
make testpassingmake fmtapplied